Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add docker-compose to CI job #939

Closed
wants to merge 1 commit into from
Closed

ci: add docker-compose to CI job #939

wants to merge 1 commit into from

Conversation

fizal619
Copy link
Contributor

@fizal619 fizal619 commented Aug 4, 2024 •
edited
Loading

What kind of change does this PR introduce?

This PR fixes the CI job that currently fails by installing docker-compose as part of the workflow.

See: https://github.com/marketplace/actions/setup-docker-compose

What is the current behavior?

Run npm t

> @supabase/[email protected] test
> run-s test:clean test:infra test:suite test:clean


> @supabase/[email protected] test:clean
> cd infra && docker-compose down

sh: 1: docker-compose: not found
ERROR: "test:clean" exited with 12[7](https://github.com/supabase/auth-js/actions/runs/10230643343/job/28322081591?pr=938#step:5:8).

What is the new behavior?

image

Additional context

image

@fizal619 fizal619 changed the title refactor: add docker-compose to CI job ci: add docker-compose to CI job Aug 4, 2024
@silentworks
Copy link
Contributor

This is likely failing because docker now recommends docker compose instead of docker-compose. I've seen this issue on other projects on GitHub and changing the command was the fix.

@fizal619
Copy link
Contributor Author

fizal619 commented Aug 9, 2024 •
edited
Loading

This was fixed in the main branch. So I'll close this PR 😅

@fizal619 fizal619 closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fizal619 @silentworks